Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: Extend Python/CApp GetCurrentFile to obtain Player's unstacked file #3440

Closed
wants to merge 1 commit into from

Conversation

arnova
Copy link
Member

@arnova arnova commented Oct 16, 2013

This extension is especially useful for our subtitles addon which currently doesn't properly handle stacked file (it currently always uses the name of the first item in the stack to create the subtitles filename).

@amet: PR for the subtitles addon will follow as soon as this has been merged

@jmarshallnz
Copy link
Contributor

Why not grab the playing file URL from the stack rather than yet another member in CApplication?

@arnova
Copy link
Member Author

arnova commented Oct 16, 2013

@jmarshallnz : Good point. Updated PR accordingly.

@jmarshallnz
Copy link
Contributor

I'm pretty sure that the need for this in the python API will disappear when subs moves to core. It might potentially be useful for other things, though I'm not sure if that's a good enough reason - there's other paths we can play that are meaningless for add-ons (e.g. musicdb:// paths).

@MartijnKaijser
Copy link
Member

Meaningless? iirc addons actually use musicdb:// paths for playing. At least i do

@arnova
Copy link
Member Author

arnova commented Oct 16, 2013

Although it's usefullness may disappear in the (near?) future for now this trivial fix, fixes a real world problem (although not life threatening ;-)) for our upcoming stable release. I can imagine there are more addons that may want to know the actual file currently being played...

@jmarshallnz
Copy link
Contributor

@MartijnKaijser: Yes, and you don't actually need the real path, right? i.e. the real path of the playing file isn't of use.

@arnova: I'm fine with it if subs don't hit core. If subs hit core, then no immediate need. They should hit core at next merge window, but let's hold this one in case something unforeseeable hits.

@ghost ghost assigned jmarshallnz Oct 17, 2013
@arnova
Copy link
Member Author

arnova commented Nov 6, 2013

@jmarshallnz : Haven't seen anything concerning subtitles yet as the end of the window is closing. Merge this then?

@jmarshallnz
Copy link
Contributor

#3552

@arnova arnova closed this Jan 18, 2014
@arnova arnova deleted the extend_python_api branch February 10, 2014 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants