-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confluence] replace subtitle flag icons with new ones #3629
Conversation
@jmarshallnz can we use png instead of gif? |
Whatever is setting the current flag(s) will need updating to use .png I think. @amet? Did you rebase away the skin.touched alteration I saw on the mail? (Good if so). |
yes rebased. |
skins can now use whatever image extension they like. |
The license for these ones looks fine, and they're better quality by the looks, so +1. |
change that @ronie linked will allow skins to control the name and the extension of the file, services will set ISO 639-1 code and skin can do with it as it pleases. |
Ukrainian flag should be named ua |
@ronie thanks for the hint .. will update it. @afedchin like @amet said it's ISO 639-1 which means uk = Ukrainian |
As discussed in xbmc#3552, this replace the subtitle flag icons with new 32x32 pixel icons from https://www.gosquared.com/resources/flag-icons/ This also fixes some wrong flags like uk. It's Ukrainian not United Kingdom.
@ronie done |
Looks like wikipedia is wrong on http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes. ISO states (see http://www.iso.org/iso/iso-3166-1_decoding_table) that "uk" was requested by the United Kingdoms but has only been reserved so far, not definitely assigned. Ukraine should be "ua". EDIT: Ah wait ISO 639.1 and ISO 3166.1 aren't the same. So for ISO 639.1 "uk" is correct, for ISO 3166.1 it would be "ua". Obviously we need X different lists of codes for the same countries ;-) |
Ukraine is indicated ua |
Right, internally ( |
@ace20022 indeed.. it's a language code not a country code ;) |
[confluence] replace subtitle flag icons with new ones
As discussed in #3552, this replace the subtitle flag icons with new
32x32 pixel icons from https://www.gosquared.com/resources/flag-icons/
This also fixes some wrong flags like uk. It's Ukrainian not United
Kingdom.