Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluence] replace subtitle flag icons with new ones #3629

Merged
merged 1 commit into from
Dec 1, 2013

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Nov 12, 2013

As discussed in #3552, this replace the subtitle flag icons with new
32x32 pixel icons from https://www.gosquared.com/resources/flag-icons/

This also fixes some wrong flags like uk. It's Ukrainian not United
Kingdom.

@xhaggi
Copy link
Member Author

xhaggi commented Nov 12, 2013

@jmarshallnz can we use png instead of gif?

@jmarshallnz
Copy link
Contributor

Whatever is setting the current flag(s) will need updating to use .png I think. @amet?

Did you rebase away the skin.touched alteration I saw on the mail? (Good if so).

@xhaggi
Copy link
Member Author

xhaggi commented Nov 12, 2013

yes rebased.

@ronie
Copy link
Member

ronie commented Nov 12, 2013

skins can now use whatever image extension they like.
see: eee7e97

@jmarshallnz
Copy link
Contributor

The license for these ones looks fine, and they're better quality by the looks, so +1.

@amet
Copy link
Contributor

amet commented Nov 13, 2013

change that @ronie linked will allow skins to control the name and the extension of the file, services will set ISO 639-1 code and skin can do with it as it pleases.

@afedchin
Copy link
Member

Ukrainian flag should be named ua

@xhaggi
Copy link
Member Author

xhaggi commented Nov 13, 2013

@ronie thanks for the hint .. will update it.

@afedchin like @amet said it's ISO 639-1 which means uk = Ukrainian
http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

As discussed in xbmc#3552, this replace the subtitle flag icons with new
32x32 pixel icons from https://www.gosquared.com/resources/flag-icons/

This also fixes some wrong flags like uk. It's Ukrainian not United
Kingdom.
@xhaggi
Copy link
Member Author

xhaggi commented Nov 13, 2013

@ronie done

@ghost ghost assigned ronie Nov 13, 2013
@Montellese
Copy link
Member

Looks like wikipedia is wrong on http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes. ISO states (see http://www.iso.org/iso/iso-3166-1_decoding_table) that "uk" was requested by the United Kingdoms but has only been reserved so far, not definitely assigned. Ukraine should be "ua".

EDIT: Ah wait ISO 639.1 and ISO 3166.1 aren't the same. So for ISO 639.1 "uk" is correct, for ISO 3166.1 it would be "ua". Obviously we need X different lists of codes for the same countries ;-)

@feruk
Copy link

feruk commented Nov 13, 2013

Ukraine is indicated ua
Ukrainian language UK

@ace20022
Copy link
Member

EDIT: Ah wait ISO 639.1 and ISO 3166.1 aren't the same. So for ISO 639.1 "uk" is correct, for ISO 3166.1 it would be "ua". Obviously we need X different lists of codes for the same countries ;-)

Right, internally (LangCodeExpander) we use "uk" for 2-letter code, "ukr" for 3-letter code and "ua" for the 2-letter region code. btw. uk for United Kingdoms makes no sense, because it's not a language ;)

@xhaggi
Copy link
Member Author

xhaggi commented Nov 13, 2013

@ace20022 indeed.. it's a language code not a country code ;)

ronie added a commit that referenced this pull request Dec 1, 2013
[confluence] replace subtitle flag icons with new ones
@ronie ronie merged commit 766165a into xbmc:master Dec 1, 2013
@xhaggi xhaggi deleted the subtitle-flags branch December 30, 2013 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants