Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvr: do not ignore scene markers for edl #3632

Merged
merged 1 commit into from
Nov 13, 2013
Merged

Conversation

FernetMenta
Copy link
Contributor

I see no reason why scene markers should be ignored. it's the only type vdr supports. with regard on vnsi this is a fix.

@opdenkamp
Copy link
Member

i don't know either. @fetzerch any idea why you commented that part out? i've overlooked that part when i pulled it

@ghost ghost assigned opdenkamp Nov 12, 2013
@fetzerch
Copy link
Member

Yes, the reason was, that Action.SCENE was commented out and I couldn't do cut.action = SCENE;
(https://github.com/xbmc/xbmc/blob/master/xbmc/cores/dvdplayer/Edl.h#L37).
So, I thought that the scene markers are disabled for some reason; Didn't knew about the AddSceneMarker. Sry.

opdenkamp pushed a commit that referenced this pull request Nov 13, 2013
pvr: do not ignore scene markers for edl
@opdenkamp opdenkamp merged commit ca7fe43 into xbmc:master Nov 13, 2013
@FernetMenta FernetMenta deleted the edl branch December 10, 2013 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants