Merge EGLSpectrum into OpenGLSpectrum and Waveform #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can test this for GLES+Linux and help with the necessary modifications to get it running. Though since we don't have any major GLES+Linux targets at the moment, I don't see any reason to hold on that. Nice work! |
… and OpenGLSpectrum viz
- sync of xcode projects
Memphiz
added a commit
that referenced
this pull request
Aug 29, 2011
Merge EGLSpectrum into OpenGLSpectrum and Waveform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
this pr merges the EGLSpectrum code into the OpenGLSpectrum and Waveform viz. So the EGLSpectrum viz is no longer needed and is removed here.
Before this pr the EGLSpectrum was both - Spectrum and Waveform addon which where selected through the settings (which was a missusage of addon settings).
After that the OpenGLSpectrum and Waveform viz behave nearly the same on linux, ios and osx including the settings.
Because i didn't find someone with another GLES plattform beside iOS to test this the OpenGLSpectrum addon will only be build for GLES on iOS. This can be changed anytime if someone with another GLES plattform has some time for testing it.
Beside that this pr removes the duplicated code of MatrixGLES and the addons are using the core MatrixGLES implementation now.
Hit it :D