Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AirTunes] - fix coverart #3848

Merged
merged 3 commits into from Dec 17, 2013
Merged

[AirTunes] - fix coverart #3848

merged 3 commits into from Dec 17, 2013

Conversation

Memphiz
Copy link
Member

@Memphiz Memphiz commented Dec 16, 2013

The coverart which is streamed from airtunes clients to XBMC had issues a long time. Finally i found some time to fix it.

  1. When the stream started - no coverart was shown. The first commit addresses this bug (basically we got the coverart before our player was in the playing state - so we had no item to at it too - fixed by delaying the coverart assignment to the OnPlay event)
  2. When changing tracks on the airtunes client the coverart was not refreshed in XBMC. The last 2 commits fix this. (1. the texture was cached in the unused texture list and since the filename doesn't change but only the content - we always got the same texture, 2. in guiwindowhome the message for refreshing thumbs wasn't send to the base class).

Thx jmarshallnz for helping to find the proper code changes.

…aying the update to the "OnPlay" event. (before we wouldn't set metadata/coverart because we get it before playback in our player really starts).
…ensure that this texture is really invalidated - and don't deliver it on the next load from unused texture list
@Memphiz
Copy link
Member Author

Memphiz commented Dec 16, 2013

jenkins build this please

Memphiz added a commit that referenced this pull request Dec 17, 2013
@Memphiz Memphiz merged commit 26c35e0 into xbmc:master Dec 17, 2013
@Memphiz Memphiz deleted the airtunesanticache branch January 14, 2014 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant