New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More gesture support #387
More gesture support #387
Conversation
Looks fine for the most part. I wonder whether the sendmessage inside the intertial handler could be done at the start (i.e. the initial GESTURE_NOTIFY message) or not - we're kinda abusing the notion of GESTURE_NOTIFY here (as we're not notifying the control that a gesture is about to start, rather we're using it to query what the current gesture is). |
Not quiet sure. TBH i rape the GESTURE_NOTIFY not for query what the current gesture is, but if the control wants inertia. So this is an abuse 100% ;). But i thought it was not intended to getting the control aware of the fact that a gesture would follow but for knowing if panning in horizontal or vertical axis is supported by the control no? Don't know how to ask it in a clean way. TBH i hope this inertia stuff will go into the new CScroller class which pieh implemented with his tweeners - someday ;). Well open for suggestions as usual for the NOTIFY abuse ... |
Well i tried to send the GESTURE_NOTIFY message on ACTION_GESTURE_BEGIN in InertialScrollingHander. But the message isn't passed to the control at that time. That is because in EVENT_RESULT CGUIWindow::OnMouseAction(const CAction &action) the m_exclusiveMouseControl is false. Exclusive Mouse Control isn't enabled until the ACTION_GESTURE_BEGIN made it to the control. So its tricky because ACTION_GESTURE_BEGIN is send to the control after CInertialScrollingHandler::CheckForInertialScrolling is finished. So it is impossible to send the NOTIFY before ACTION_GESTURE_BEGIN is completly through the chain ... |
If no other complains or solutions are comming in - i'll rebase and merge it ... |
…ERTIA" returns on ACTION_GESTURE_NOTIFY - and deactivate inertia of the win32 api in that case
…ch have native inertial panning support (only win32 for now...)
- make guislidercontrol gesture pan aware (without intertial scrolling)
- swipe left and right - next/prev slide - pinch - zoom - when zoomed in - pan for moving inside the picture
Update to allow for Newzbin merging H.264 and x264 attributes into a … …single H.264/x264 attribute.
This PR will add the following: