dvdpalyer audio: fix delivering the packet in wrong format #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
added a commit
that referenced
this pull request
Dec 31, 2013
dvdpalyer audio: fix delivering the packet in wrong format
|
Nice catch. Evil to do state update in public Getter API. A comment would have been nice on the call, so nobody cleans it out. |
|
This was an intermediate fix for Gotham. I intend to touch this again after release: ActiveAE can handle planar formats so we don't have to convert to interleaved here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dvdplayer delivered the first audio packet unconverted. with some codecs like ADPCM this killed the order of bytes of the stream delivered to AE which led to crackling sound.
fixes trac: http://trac.xbmc.org/ticket/14771