New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace header background image #3971
Conversation
Nice! |
Better indeed |
Yes indeed, That's what I was working towards, 👍 About the header label font types? All dialogs use font13_title except settings/info/profile. Because however font13_title is shorter doesn't look as good throughout. Would you like me to have a stab at these and make them all font16? And if so the dialogheader.png now also needs to stretch to 52 because this texture is set at 40 in these other places too.. there's quite a few more of these though ;-) In any case this is 20 steps in right direction, thank you @ronie. |
To my comments above to this PR I pulled your changes into a branch and added my changes ontop.
un1versal@68dccb4 refines the header label fonts in weather and fixes alignment (somehow 20 was a bit too low) un1versal@6744513 Really takes this a step further and looks at what I could find, that was sort of applicable to the points above.
I dondt wanna make a commnet without showing what I was looking at. |
In general +1, but not sure I like it in it's current state. Settings header is visually better, but the font should be aligned left as it's no window header (not spanning the entire window), plus it would "jump" less when you switch settings sections. But that's probably just my taste. |
@da-anda the label is centered because the highlight is also centered. it looks better that way imo. i've updated the image as you suggested:
@UniversaI the fonts on the dialogs should remain as they are.
nope, you can't compare the size of an image on a fullscreen window to the same image in a small dialog. |
Just to add from a design point of view, it looks good centered to me. |
good for me now, thanks @ronie (the only thing I don't like now is the way too big weather provider logo overlaping everything, but that's a different story) |
tweaked the weather stuff as suggested (smaller logo, better alignment of header label) |
this is a cleanup of #3940
it replaces the header background texture in a number of places, to improve readability.
for @universal