-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to enable c++11 compilation #4024
Conversation
a thing I forgot: I didn't build xbmc with all features enabled, it may be that there are still places which need to be adjusted |
We're in feature freeze for Gotham now, so superfluous changes like this |
So I'll just leave it open for the next release after Gotham. |
Great. Thanks for understanding. We'll revisit this post Gotham. |
@lorem-ipsum |
Yup, give me a few days, I'm a bit busy right now |
without a space after " compilation with -std=c++11 fails, because it assumes the macro to be a string suffix, which it does not know / which is invalid, because it doesn't start with a underscore
c++11 introduced a std::shared_ptr. With using namespace std and boost the declaration without explicit namespace is invalid
A bit more than a few days, but now it should work again |
c++11 supports explicit operator bool, which is used by newer boost if c++11 is enabled, breaking the implicit conversions. A comparision to NULL is used instead
Comparision against NULL is nicer than the explicit cast, I updated the branch and i merged your changes to ThreadMessage instead of my hacks. |
Thanks! jenkins build this please |
Minor changes to enable c++11 compilation
This adds several minor changes to allow compilation of xbmc with -std=c++11 (tested with clang-3.4).
Almost all changes are just syntax changes, which shouldn't change anything in the result. Only exception is commit 4feadca which changed the type of two macros from unsigned to signed, because it would lead to impossible narrowing