[rbp/omxplayer] Fixed: analog output was not properly enabled #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a case sensitive settings check Commit 67e957d changed the driver name from "Pi" to "PI"
|
Ah - good spot. |
popcornmix
added a commit
that referenced
this pull request
Jan 30, 2014
[rbp/omxplayer] Fixed: analog output was not properly enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@popcornmix: the RPi analog output was not properly enabled due to a case sensitive settings check.
Commit 67e957d from @FernetMenta changed the driver name from "Pi" to "PI".
As a result, the audiodevice name in the guisettings.xml becomes "PI:Analogue".
Due to the case mismatch, the analogue output was never enabled without manually changing the name back to "Pi:Analogue" in the guisettings.xml.