Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup FileItem::IsSamePath #4345

Merged
merged 2 commits into from Mar 11, 2014
Merged

Speedup FileItem::IsSamePath #4345

merged 2 commits into from Mar 11, 2014

Commits on Mar 9, 2014

  1. Speedup FileItem::IsSamePath 

    IsSamePath has been found to be expensive if PR 4301 is applied and
used, where a large number of updates a second may occur.

By switching IsMusicDB and IsVideoDB to use the URIUtils versions. A
simple string compare is used, rather than an expensive URL parser
to check the protocol.
    @cg110
    cg110 committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    6950e46 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2014

  1. If available use videoInfoTags in IsSamePath 

    If VideoInfoTags are available, then comparing the DBId and the Type is
good enough for testing two items are the same path.

Benchmarking shows that this change reduces the time to compare 340 movies
from 10ms to <1ms.
    @cg110
    cg110 committed Mar 10, 2014
    Configuration menu
    Copy the full SHA
    17a90a4 View commit details
    Browse the repository at this point in the history