JSON-RPC: make logging of incoming requests optional and configurable #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - thanks :) jenkins build this please |
jmarshallnz
added a commit
that referenced
this pull request
Mar 15, 2014
JSON-RPC: make logging of incoming requests optional and configurable
jmarshallnz
added a commit
that referenced
this pull request
Mar 15, 2014
JSON-RPC: make logging of incoming requests optional and configurable
|
are there other location you forgot in this pr? checkout out this log, even the user complained: http://forum.xbmc.org/showthread.php?tid=192225&pid=1694224#pid1694224 |
|
Looks like he's either running a very outdated addon or a very bad third party app. First of all there are a ton of HTTP-API requests in the log which was already removed for Frodo. And then it looks like someone is hammering our TCP server with quick connects/disconnects which is obviously not how it should be used. This PR was solely about the output of JSON-RPC calls I didn't consider anyone abusing our TCP server like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the forums the first commit makes the logging of incoming JSON-RPC requests optional. For JSON-RPC requests over HTTP there is still a debug log message from the webserver (which is not JSON-RPC specific) but I guess most of the JSON-RPC log spam comes from JSON-RPC requests of python addons. And a lot of remotes use JSON-RPC over TCP.
The second commit reduces the log level of a log JSON-RPC log message from ERROR to WARNING. The problem is that at the time we don't know if it's actually an error or not. There are cases where it will be an error and others where it can resolved later on. So logging it as a WARNING should be less confusing.