Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] add config file for env vars and suspend pulse if AE_SINK=alsa #4480

Closed
wants to merge 1 commit into from

Conversation

wsnipex
Copy link
Member

@wsnipex wsnipex commented Mar 28, 2014

This allows to put our supported environment variables in a config file userdata/envvars.conf.
Main use case is for using Alsa even when pulse is installed. If AE_SINK=alsa is specified, pulse will be suspended via pavucontrol when starting xbmc. After exit, pulse will be resumed.

If acceptable, I'd like to get this in for gotham, as it could fix a problem for xbmcbuntu.
We could install pulse by default for the desktop session without having to deal with its limitations(no HD audio).

@fritsch ping

@fritsch
Copy link
Member

fritsch commented Mar 28, 2014

I see the usecase for xbmcbuntu and also for appliances like OpenELEC, that want to integrate "more than xbmc" in the future. It's okay from my side. For endusers it is a bit hard to need to edit yet another config file, though.

@t-nelson
Copy link
Contributor

I'm really not interested in adding yet another place to configure xbmc.
Especially a platform specific one like this.

@wsnipex
Copy link
Member Author

wsnipex commented Mar 28, 2014

well, there is no other place for this atm. This just adds a unified way to pass our env vars, which can already be passed to xbmc.
Adding it to normal settings would require significant changes, if at all possible. I'm open for suggestions.

@MartijnKaijser MartijnKaijser modified the milestone: Pending for inclusion May 2, 2014
@topfs2
Copy link
Contributor

topfs2 commented Aug 24, 2014

Personally I think this is not something we should manage in xbmc. Its up to xbmcubuntu and openelec and others to have their own way to manage the env vars needed. I personally think we should just behave sanely as an application here, either we can connect to pulse or not.

I do understand the need for it but feels misplaced to have it in xbmc source IMO.

@topfs2 topfs2 removed the Helix label Sep 23, 2014
@MartijnKaijser MartijnKaijser removed this from the Pending for inclusion milestone Jun 14, 2015
@wsnipex wsnipex closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants