settings: fix detection of value changes in CSettingList #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx for the fix :) |
t-nelson
added a commit
that referenced
this pull request
Apr 4, 2014
settings: fix detection of value changes in CSettingList
t-nelson
added a commit
that referenced
this pull request
Apr 5, 2014
settings: fix detection of value changes in CSettingList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the detection of whether the value of a CSettingList setting is the default value or not. This is relevant in combination with the fact that we now store whether a value is the default value or not in guisettings.xml. Because of the inverted logic right now we don't load changed CSettingList setting values because we think they are default values.