Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epg] Fix navigating to the sidebar with cursor keys #4527

Merged
merged 1 commit into from
Apr 16, 2014

Conversation

Jalle19
Copy link
Member

@Jalle19 Jalle19 commented Apr 5, 2014

When setting epg.lingertime to zero (which means past EPG data is disabled and you can access the sidebar by pressing left when you're at the leftmost item) two Left-presses are required to open the sidebar if you've previously moved up or down in the timeline. If you move one programme to the right on a channel and then start going left the sidebar opens on the first attempt as expected.

This is because m_item is wrongly set when changing channels (ie. moving up and down) because the m_channelCursor variable is only updated after the new item has been determined, which causes the wrong item to end up as m_item.

@xhaggi could you review?

If #4526 gets merged for Gotham I think this should too.

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 5, 2014

@opdenkamp could you take a look at this? I'm not very familiar with this code.

@xhaggi
Copy link
Member

xhaggi commented Apr 5, 2014

i'll do a review when I have time

if (m_item)
{
SetBlock(GetBlock(m_item->item, channel));
m_channelCursor = channel;

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@Jalle19
Copy link
Member Author

Jalle19 commented Apr 7, 2014

@xhaggi updated (don't know why I didn't opt for this approach from the beginning) and it still works.

@xhaggi
Copy link
Member

xhaggi commented Apr 7, 2014

Thanks ;) .. @t-nelson your button.

@t-nelson
Copy link
Contributor

Since @opdenkamp declined #4526 for Gotham, is this a no-go as well?

@xhaggi
Copy link
Member

xhaggi commented Apr 15, 2014

fine with me so up to RMs

@t-nelson
Copy link
Contributor

@opdenkamp opinion?

@opdenkamp
Copy link
Member

didn't test, but looks okay. as for #4526 : i am only against changing the default value to 0

t-nelson added a commit that referenced this pull request Apr 16, 2014
[epg] Fix navigating to the sidebar with cursor keys
@t-nelson t-nelson merged commit 3c90d9d into xbmc:master Apr 16, 2014
t-nelson added a commit that referenced this pull request Apr 16, 2014
[epg] Fix navigating to the sidebar with cursor keys
@t-nelson t-nelson removed the Gotham label Apr 16, 2014
@MartijnKaijser MartijnKaijser modified the milestones: Helix 14.0-alpha1, Gotham13.0-rc1 May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants