-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[epg] Fix navigating to the sidebar with cursor keys #4527
Conversation
@opdenkamp could you take a look at this? I'm not very familiar with this code. |
i'll do a review when I have time |
if (m_item) | ||
{ | ||
SetBlock(GetBlock(m_item->item, channel)); | ||
m_channelCursor = channel; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@xhaggi updated (don't know why I didn't opt for this approach from the beginning) and it still works. |
Thanks ;) .. @t-nelson your button. |
Since @opdenkamp declined #4526 for Gotham, is this a no-go as well? |
fine with me so up to RMs |
@opdenkamp opinion? |
didn't test, but looks okay. as for #4526 : i am only against changing the default value to 0 |
[epg] Fix navigating to the sidebar with cursor keys
[epg] Fix navigating to the sidebar with cursor keys
When setting epg.lingertime to zero (which means past EPG data is disabled and you can access the sidebar by pressing left when you're at the leftmost item) two Left-presses are required to open the sidebar if you've previously moved up or down in the timeline. If you move one programme to the right on a channel and then start going left the sidebar opens on the first attempt as expected.
This is because m_item is wrongly set when changing channels (ie. moving up and down) because the m_channelCursor variable is only updated after the new item has been determined, which causes the wrong item to end up as m_item.
@xhaggi could you review?
If #4526 gets merged for Gotham I think this should too.