FIX: No files are returned from JSON-RPC Files.GetDirectory for http sources #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t also for files. This broke CFileOperations::GetDirectory for http as the item is rejected if it is a directory in CFileOperations::FillFileItem.
|
If cfilecurl set that flag somewhat properly, patch is okey. |
|
If what is read has mime-type text/html, it is assumed to be a directory. It is explicit at FileCurl.cpp:1149 |
elupus
added a commit
that referenced
this pull request
Oct 6, 2011
FIX: No files are returned from JSON-RPC Files.GetDirectory for http sources
tru
pushed a commit
to plexinc/plex-home-theater-public
that referenced
this pull request
Jan 31, 2013
Hopefully fixes xbmc#458
koying
added a commit
to koying/xbmc
that referenced
this pull request
Nov 27, 2017
FIX: mouse handling when FB size != GUI size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHTTPDirectory::Exists is returning true not only for directories but also for files.
This breaks CFileOperations::GetDirectory for http as the item is rejected if it is a directory in CFileOperations::FillFileItem.
The result is that no files are returned from JSON-RPC for http sources.
This patch uses CFileCurl::Stat rather than CFileCurl::Exists.