[guilib] Drop back compatibility code and inconsistencies #4613
Conversation
|
The label changes means a fix for the case where center align is used and the label gets cut off, right? Thats a bug every skinner has learned to live with and is used quite a lot. But I do think it should be fixed and if backwards compatibility is kept on API version, I have no problems with that. I can do the changes for confluence if this gets merged. |
|
Yup, exactly. As it's a far-reaching change (not confined to one or two XMLs) I'd support backcompat staying on that for the entire cycle if skinners feel they need it. There'll be plenty of other things they'll need to change by the looks... |
|
Hmm, didn't make that obvious. It fixes the case where align center or right means that Outside a list as far as I'm aware everything is working fine with |
|
yeah, I meant in a list. Currently you'd have to adjust the left position to the center to get a center aligned label inside a list. |
|
Confluence has 12 lists across 5 xmls that use this workaround. So it's less of a problem then I thought and pretty easy to detect. |
Skins for 14.X should use a single background image (id 999) with border. and must have a grouplist with id 996 for the context menu.
… python guilib stuff)
… buttons. For v14 ensure the following controls are edit controls: SmartPlaylistEditor.xml: id 12, name of smart playlist SmartPlaylistRule.xml: id 17, value of rule DialogMediaSource.xml: id 12, name of media source DialogNetworkSetup.xml: id 11, server address id 13, port id 14, username id 15, password id 16, remote path
…XbmcApiVersionDependency
…ners. It previously defaulted to keep unless the image was constant (not infoimage) where it defaulted to stretch. It now defaults to stretch like all images.
… <left> now mean left
|
Rebased. jenkins build this please |
|
i'll try to finish the label/image fixes for Confluence soon-ish, |
[guilib] Drop back compatibility code and inconsistencies
[confluence] change buttons to edit controls (see #4613)
This drops some old backward compatibility code for skins. The aspect ratio change and label positioning changes are kept but are now switched based on the API version the skin requires, allowing a bit of time for skinners to adapt (the skins still work, but they look a bit odd in places).
I'm fairly sure no skin is using the old context menu stuff (context menu without a grouplist), so didn't bother with backward compatibility there.
@ronie, @BigNoid, @Black09, @JezzX please feel free to comment. Confluence will need updating for the label change (labels in lists now have
<left>meaning left) and the aspect ratio change (all images default tostretchnow - before infoimages in lists defaulted tokeep).Closer to release of Helix we can decide whether to drop the backward compatibility completely or not. e.g. if there's other, breaking changes made.