Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rfc] [coreSubs]Automatically download first subtitle after first search #4648

Merged
merged 1 commit into from
May 17, 2014
Merged

[rfc] [coreSubs]Automatically download first subtitle after first search #4648

merged 1 commit into from
May 17, 2014

Conversation

fape
Copy link
Contributor

@fape fape commented May 4, 2014

  • Automatically download first subtitle after first search (you can select manually from the next search)
  • Add new settings item to enable/disable auto downloading

@MartijnKaijser
Copy link
Member

without looking into the code (or knowing it) would this always download the first sync subtitle when opening the dialog? You are still able to pick another one right, if you reopen it or already have a subtitle file available?

@fape
Copy link
Contributor Author

fape commented May 4, 2014

Good question. Now I need to say: No you can not.
But I'm going to implement it. Thanks.
Later I can combine this pr with my other pr ( #4458 ) to auto download first preferred sync subtitle.

@fape fape changed the title [rfc] Automatically download first sync subtitle after search [wip] [rfc] Automatically download first sync subtitle after search May 4, 2014
@fape
Copy link
Contributor Author

fape commented May 4, 2014

@MartijnKaijser Updated, thanks for your suggestion.

@fape fape changed the title [wip] [rfc] Automatically download first sync subtitle after search [rfc] Automatically download first sync subtitle after search May 4, 2014
@bthusby
Copy link

bthusby commented May 4, 2014

Please make it possible to downoad first sync'ed subtitle. Even better, have an option to do it by default for your chosen ordered languages when a movie or tv show starts.

Right now it takes ages to find available subtitles in multiple subtitle addons, and then it takes ages again to download the one you want, all this while the movie/tv show is paused or running in the background hidden behind the subtitle choosing dialague box... On top of this my ATV2 installation more often than not crashes during this search, and reboots :(

amet
amet reviewed May 5, 2014
View reviewed changes
xbmc/video/dialogs/GUIDialogSubtitles.cpp
@@ -185,6 +189,12 @@ void CGUIDialogSubtitles::OnInitWindow()
Search();
}

void CGUIDialogSubtitles::Announce(ANNOUNCEMENT::AnnouncementFlag flag, const char *sender, const char *message, const CVariant &data)
{
if(m_autoDownloaded && flag == ANNOUNCEMENT::Player && StringUtils::EqualsNoCase(message, "OnStop"))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@amet
Copy link
Contributor

amet commented May 5, 2014

ah, its late here ... you are right :)

@t-nelson
Copy link
Contributor

t-nelson commented May 5, 2014

Isn't there an implication of piracy support here? Not sure I'm
comfortable with such a thing in core...

@amet
Copy link
Contributor

amet commented May 6, 2014

@fape could you get in touch on IRC or on mail regarding this please.

@fape
Copy link
Contributor Author

fape commented May 6, 2014

Of course. If you don't mind I prefer the email. Feel free to write me fape88[at]gmail[dot]com

Jalle19
Jalle19 reviewed May 6, 2014
View reviewed changes
language/English/strings.po

#: system/settings/settings.xml
msgctxt "#24127"
msgid "Automatically download first sync subtitle from the search result list"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@fape fape changed the title [rfc] Automatically download first sync subtitle after search [wip][rfc] Automatically download first sync subtitle after search May 10, 2014
@fape fape changed the title [wip][rfc] Automatically download first sync subtitle after search [rfc] Automatically download first subtitle after first search May 11, 2014
@fape fape changed the title [rfc] Automatically download first subtitle after first search [rfc] [coreSubs]Automatically download first subtitle after first search May 11, 2014
@amet
Copy link
Contributor

amet commented May 11, 2014

Works for me, @t-nelson, @jmarshallnz ?

jmarshallnz
jmarshallnz reviewed May 11, 2014
View reviewed changes
xbmc/video/dialogs/GUIDialogSubtitles.cpp
@@ -105,6 +106,9 @@ CGUIDialogSubtitles::CGUIDialogSubtitles(void)
m_serviceItems = new CFileItemList;
m_pausedOnRun = false;
m_updateSubsList = false;
m_autoDownloaded = false;

ANNOUNCEMENT::CAnnouncementManager::AddAnnouncer(this);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@amet
Copy link
Contributor

amet commented May 15, 2014

@fape please remove announcements and save the path of the item as per @jmarshallnz suggestion , then it can go in

@fape
Copy link
Contributor Author

fape commented May 15, 2014

Ok, thanks! I'll do it after work, Hopefully today.

@Steini1984
Copy link

I see that opensubtitles atleas has the "Sync" symbol in Gotham. Could that be used to download the first sync?

Then comes part nr 2 of my thought. If it is possible to download the first "Sync" Subtitle it would be great to only show the subtitle menu when no synced sub is found (just like it was in Frodo)

That would mean a distraction free subtitle download using a remote (unless no sync sub can be found)

@fape
Copy link
Contributor Author

fape commented May 16, 2014

@amet, @MartijnKaijser: Updated!

@amet
Copy link
Contributor

amet commented May 17, 2014

jenkins build this please

jmarshallnz
jmarshallnz reviewed May 17, 2014
View reviewed changes
language/English/strings.po
msgstr ""

#: system/settings/settings.xml
msgctxt "#24127"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@MartijnKaijser
Copy link
Member

jenkins build this please

jmarshallnz added a commit that referenced this pull request May 17, 2014
@jmarshallnz
Merge pull request #4648 from fape/subtitles_downloadfirstsync
9100d0a 
[rfc] [coreSubs]Automatically download first subtitle after first search
@jmarshallnz jmarshallnz merged commit 9100d0a into xbmc:master May 17, 2014
@fape fape deleted the subtitles_downloadfirstsync branch May 18, 2014 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Helix 14.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@fape @MartijnKaijser @bthusby @amet @t-nelson @Steini1984 @jmarshallnz @Jalle19 @Crossbow78