-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop CStdStringArray, SplitString, JoinString #4684
Conversation
@@ -1030,7 +1030,7 @@ int CGUIInfoManager::TranslateSingleString(const CStdString &strCondition, bool | |||
} | |||
if (prop.name == "property") | |||
{ | |||
if (prop.param().Equals("fanart_image")) | |||
if (prop.param() == "fanart_image") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Gone through all the changes. Very nice work. Looks like you've found some nice code simplifications as well. |
Thanks - have fixed up your comments - most appreciated. |
Nice and big job! |
Thanks - I'll fix some of the cosmetics, but won't bother with most of them when the same files are using vector already over and over. IMO |
…bidi flipping now that we no longer do the flipping here
…ing> instead of CStdStringArray
…tdStringArray usage
…itString to StringUtils::Split
…<string> rather than vector<CStdString>
…n vector<CStdString>
…re they have a comma separated pair
…d use StringUtils::Tokenize() instead of Split() to ignore empty tokens
jenkins build this please |
Drop CStdStringArray, SplitString, JoinString
Mostly cleanup, though there are a few fixes here as well.
The ones I'm really not sure about are designated with the REVIEW subscript.
@davilla, @koying: Please see 0a6ae3a
@Montellese: please check d813aba, 67b10ff, and dee673f
@Karlson2k Perhaps you could review in detail - most of the changes are straightforward, but the odd one or two are a little more. I anticipate this will go in at the end of the June merge window.