Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CStdStringArray, SplitString, JoinString #4684

Merged
merged 28 commits into from
Jun 12, 2014

Conversation

jmarshallnz
Copy link
Contributor

Mostly cleanup, though there are a few fixes here as well.

The ones I'm really not sure about are designated with the REVIEW subscript.

@davilla, @koying: Please see 0a6ae3a

@Montellese: please check d813aba, 67b10ff, and dee673f

@Karlson2k Perhaps you could review in detail - most of the changes are straightforward, but the odd one or two are a little more. I anticipate this will go in at the end of the June merge window.

@@ -1030,7 +1030,7 @@ int CGUIInfoManager::TranslateSingleString(const CStdString &strCondition, bool
}
if (prop.name == "property")
{
if (prop.param().Equals("fanart_image"))
if (prop.param() == "fanart_image")

This comment was marked as spam.

This comment was marked as spam.

@Montellese
Copy link
Member

Gone through all the changes. Very nice work. Looks like you've found some nice code simplifications as well.

@jmarshallnz
Copy link
Contributor Author

Thanks - have fixed up your comments - most appreciated.

@Karlson2k
Copy link
Member

Nice and big job!
I'd use ctor initializer instead of default ctor + assignment.
And, mostly cosmetics, add std:: to string and vector.

@jmarshallnz
Copy link
Contributor Author

Thanks - I'll fix some of the cosmetics, but won't bother with most of them when the same files are using vector already over and over. IMO using namespace std in a .cpp file is sometimes the lesser evil to all the replication that is otherwise in place. Treated carefully, ofc - if there's not much use of it, then no problem with the prefix.

@MartijnKaijser MartijnKaijser added this to the Pending for inclusion milestone May 21, 2014
Jonathan Marshall added 20 commits June 12, 2014 17:10
…bidi flipping now that we no longer do the flipping here
@jmarshallnz
Copy link
Contributor Author

jenkins build this please

jmarshallnz added a commit that referenced this pull request Jun 12, 2014
Drop CStdStringArray, SplitString, JoinString
@jmarshallnz jmarshallnz merged commit 434e21a into xbmc:master Jun 12, 2014
@jmarshallnz jmarshallnz deleted the drop_stdstringarray branch June 12, 2014 09:24
@MartijnKaijser MartijnKaijser modified the milestones: Helix 14.0-alpha1, Pending for inclusion Jun 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants