New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control access cleanup #4739
Merged
Merged
Control access cleanup #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Montellese mind taking a look at number 1 when you get the chance? |
Looks fine by me as that's how it's used in other cases as well. |
I could add a define (it would save a few lines in the few spots it's used atm). |
…it obvious what it does
…rying radiobuttons directly
…a spinner rather than querying it directly
… use it in preference to direct setting on the control
…om an image control instead of querying directly
…hing info from edit controls rather than direct access
jenkins build this please |
This was referenced Feb 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work of #4731 cleaning up direct access to controls and replacing it with messages.
There's a couple of things to review:
There's a reasonably trivial change in the PVR guide stuff which I think can be clarified. @xhaggi, @opdenkamp, @Jalle19 please take a look at 0612a4a specifically, though a lot of this applies to the PVR dialog classes.Assuming 1 is acceped (or a better solution is suggested) I'll go through and redo other spots filling a spinner via the GUI_MSG_LABEL_RESET, GUI_MSG_LABEL_ADD, GUI_MSG_ITEM_SELECT technique which is inefficient as you're looking up the control for each message.