Font manager cleanup #4740
Merged
Font manager cleanup #4740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2014 13:42
|
I was wondering the other day if it would be possible to show the present the list of fonts that can be chosen (eg subtitle font selector) in the font itself. (like http://www.wavian.com/fonts/fontlist1.gif) If this isn't directly related please ignore me. |
|
@Karlson2k mind reviewing? |
|
@kibje yeah, unrelated. This is choosing the fontset, which could actually consist of multiple fonts, and they're not loaded (well, only one set are loaded). |
|
jenkins build this please |
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
jeroenpardon
pushed a commit
to jeroenpardon/skin.refocus
that referenced
this pull request
Dec 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some font manager related stuff. We only ever loaded fonts that had the unicode='true' set, so all the code to determine whether we had the attribute set was a waste of time.