FIX: [sets] actually allow to delete sets #4754
Conversation
| if (type == VIDEODB_CONTENT_MOVIE_SETS) | ||
| { | ||
| CFileItemList items; | ||
| CDirectory::GetDirectory(item->GetPath(),items,"",DIR_FLAG_NO_FILE_DIRS); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Why is this labeled as a fix? This funcationality simply didn't exist up until now. |
|
The context menu item is there, but it does nothing. |
|
Ah okay, I thought since you had to extend CanDeleteVideoItem() there shouldn't have been a context menu entry. |
|
BTW, apparently the nav window was not cleaned when the manage one was created, so I think there is a bunch of dead code there, e.g. the removal of sets. |
|
updated |
| database.DeleteSet(params.GetSetId()); | ||
|
|
||
| return true; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jmarshallnz Ok for you? jenkins build this please |
|
Fine by me, yup. |
|
Unrelated jenkins fail |
FIX: [sets] actually allow to delete sets
Nowadays, doing a delete on a set does nothing
/cc @jmarshallnz