settings: a setting should be disabled if its parent setting is disabled #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! I based #4715 on this. looks good. |
|
Thanks for trying it out so fast and reporting back. |
|
jenkins build this please |
jmarshallnz
added a commit
that referenced
this pull request
May 24, 2014
settings: a setting should be disabled if its parent setting is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some logic to the settings system to automatically disable all child settings if the parent setting is disabled. IMO having an enabled child setting if the parent setting is disabled doesn't make much sense and would look odd.