[osx] utilize planar support from AE in the OSX sink #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* For planar audio we set m_frameSize to be the size per plane */ | ||
| if (m_planes > 1) | ||
| m_format.m_frameSize /= m_planes; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Updated. Also included some fixes for bitstreaming (which is likely not going to be planar, but at least it now correctly takes things from the planes if it is) and a bit of cleanup. @Memphiz mind reviewing? jenkins build this please |
|
Retested (slight changes compared to the "previous" implementation) against kXAudioDriver, still gives flawless audio output for all channel setups and all input sample rates. Can't test S/PDIF passthrough though. AppleHDA 2-channel-interleaved remains intact. |
|
looks good to me :) |
|
Thanks! Will rebase down and build test. |
added 5 commits
May 26, 2014 09:41
…ultiple small memcpy's and it's not as if we're performance constrained here
… rather than m_format.m_sampleRate
|
jenkins build this please |
jmarshallnz
added a commit
that referenced
this pull request
May 25, 2014
[osx] utilize planar support from AE in the OSX sink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Memphiz @FernetMenta please take a look. Thanks!