[omxplayer] Allow small audio packets to be concatenated to make better use of audio fifo #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
@huceke for review please |
…er use of audio fifo Some audio codecs produce small packets which causes a high overhead when submitting to GPU, and doesn't make full use of GPU side buffering. TrueHD in particular can produce packets with 40 samples (so 1200 packets per second) which causes very high overhead. What this aims to do is to concatenate audio packets until they approach the ideal audio packet size, and then deal with the awkardness of concatenated planar formats.
I've also added caching to the call to OMXMediaTime as the GPU round trip is expensive when called too frequently
|
jenkins build this please |
|
@popcornmix: hit the green button ;) |
popcornmix
added a commit
that referenced
this pull request
May 25, 2014
[omxplayer] Allow small audio packets to be concatenated to make better use of audio fifo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some audio codecs produce small packets which causes a high overhead when submitting to GPU, and doesn't make full use of GPU side buffering.
TrueHD in particular can produce packets with 40 samples (so 1200 packets per second) which causes very high overhead.
What this aims to do is to concatenate audio packets until they approach the ideal audio packet size, and then deal with the awkardness of concatenated planar formats.
The second commit uses the media time for determining the audio delay more accurately.