[Pydocs] Add info for Player and RenderCapture #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added information in comments to be pulled into PyDocs describing the shortcomings when calling xbmc.player.getPlayingFile() for LiveTV. Specifically that pvr:// url's are not translated into usable filenames or streams. 2) Added information to xbmc.CapturePlayer regarding the functions getHeight() and getWidth() which return 0 prior to calling CapturePlayer.capture(). Also added that getAspectRatio() may be called prior to issuing a capture() request.
|
thank you :) |
|
Ok. My past use of github was always with a small number of ppl. I'm still learning how to negotiate with the more advanced stuff from the Git Bash shell. Again, thanks for the patience. |
|
No worries - we appreciate your contribution (and taking the time to learn new stuff!) |
jmarshallnz
added a commit
that referenced
this pull request
May 25, 2014
[Pydocs] Add info for Player and RenderCapture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shortcomings when calling xbmc.player.getPlayingFile() for LiveTV.
Specifically that pvr:// url's are not translated into usable filenames
or streams.
getHeight() and getWidth() which return 0 prior to calling
CapturePlayer.capture(). Also added that getAspectRatio() may be called
prior to issuing a capture() request.