Fix tag reading for some broken files, fixes #15239 #4792
Conversation
|
@jmarshallnz Could you review it? jenkins build this please |
|
jenkins build this please |
|
@jmarshallnz Updated with comment. No need to restart jenkins builds. :) |
| return; // wrong Position value | ||
|
|
||
| // When parsing some broken files, taglib may try to seek above end of file. | ||
| // If underlying VFS does move I/O pointer in this case, taglib will parse |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…fied length in header is longer than actual file length)
|
@jmarshallnz Updated again. |
|
I'd suggest all except the winsmb change is merged to Gotham (as that has the potential to break things which are currently handling the error). Sound good? If so, mind doing a backport PR for me? |
Fix tag reading for some broken files, fixes #15239
|
Sounds good and correct. |
|
Dropping Gotham tag since we've got the other PR for the right bits |
Fix for http://trac.xbmc.org/ticket/15239