-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: [droid] depends configure.in borked #4816
Conversation
jenkins build this please |
Just as a data point, I configured + built depends just fine yesterday (fresh git checkout, fresh depends, no tarballs etc.) That was ARM, not x86. |
Yes, but no arm specific flags are passed, especially neon (check makefile.include). |
Nevermind. This is just plain wrong. Proper "fix" (as in make android ok again) is to revert 2ab82eb |
@davilla Comments? |
I have no comments nor will I participate in fixing the mess others are make in there. |
Ooookeeee. As no primary parties seem interested in fixing the mess, I'll just commit this one and wash my hand of it. |
@koying the only changes are the added spaces in the platform flags right? If so - ok from me. |
... And you now have to add "--enable-neon" in the configure line of the depends for Android. |
I've added this on request, the reasoning being that we CAN build without it. As said on IRC, if this doesn't make any sense and we require neon in any case, then just remove the switch and hardcode neon. |
Ok. Reverting both commits, then. jenkins build this please |
FIX: [droid] depends configure.in borked
/cc @wsnipex @davilla