[osx] - only show the fake fullscreen option on snow leopard #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning on snowleopard - it leads to black screen on all later osx versions
|
jenkins build this please |
|
Settings stuff looks ok. |
| if (isSnowLeopard == -1) | ||
| { | ||
| double appKitVersion = floor(NSAppKitVersionNumber); | ||
| isSnowLeopard = (appKitVersion <= NSAppKitVersionNumber10_6 && appKitVersion > NSAppKitVersionNumber10_5) ? 1 : 0; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jmarshallnz
added a commit
that referenced
this pull request
Jun 12, 2014
[osx] - only show the fake fullscreen option on snow leopard
|
@Memphiz: mind backporting to Gotham? SettingConditions.cpp doesn't existing in Gotham branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On later OSX versions this setting leads to black screen (deep core sdl issue we don't wanna fix ...). There are some users already who have locked theirselfs out because of this.
Please consider it for Gotham.
@Montellese - i think i got it - but i just wanna ping someone about it :D