Pushed subtitle offset default from +-10s to +-60s #4929
Conversation
|
Makes sense. Although rare, I've ran into this myself a couple of times in the past. |
|
I haven't looked at the affected code. Does this reduce resolution or just take forever to get to the ends? |
|
I believe mainly the latter since we don't increase speed on eg. button hold. |
|
Right so the step is fixed rather than being max/100 or similar. Usability |
|
This usually happens when the subtitles and the video you're watching have commercials cut differently. This tends to introduce many seconds of desync, and after a few commercials 10 seconds is not enough to compensate. |
|
Yup, that is probably the main reasons behind my desync. @t-nelson Its true that the usability gets a bit different here, its harder to notice if the slider goes left or right, however with keys that should be a no problem since you know if you pressed left or right. On touch/mouse devices the resolution gets trickier, I haven't tried it there. But from a usability standpoint the slider is not ideal in this, what happens with the sub when you go left is not obvious, I know that I generally just try both and see what makes it better :P Combine this with that ideally we probably wouldn't even want a roof of how much you alter the sync. Perhaps a more long time solution would be to reinvent the popup entirely which solves both usability and UX. IMO however this is a good temporary solution, atleast on stb |
|
+1 |
|
Ok if I pull this next window? |
|
Fine by me |
|
jenkins build this please |
Pushed subtitle offset default from +-10s to +-60s
While this is perfectly doable for anyone via advancedsettings.xml I think it might be valid to make the default a bit larger than 10s. What I've seen when used offset is that either its syncing alright and then +-10s is fine to make it ok for the entire video, or its drifting (not sure why it drifts but) and then 10s is far from enough.