Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xml attribute tidy up #4971

Merged
merged 13 commits into from Jul 1, 2014
Merged

Xml attribute tidy up #4971

merged 13 commits into from Jul 1, 2014

Commits on Jun 30, 2014

  1. [xmlutils] adds helper GetAttribute for retrieving a std::string vers… 

    …ion of an attribute
    Jonathan Marshall committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    06626d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2014

  1. [xmlutils] use XMLUtils::GetAttribute() when assigning attributes dir… 

    …ectly to CStdString/std::string, as they may be NULL
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    4d16040 View commit details
    Browse the repository at this point in the history

  2. [xml] fix potential null pointer dereference when reading attributes

    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    2ce4ccc View commit details
    Browse the repository at this point in the history

  3. [addons] make the 'type' attribute of addon settings consistently com… 

    …pared case-sensitive
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    2eecefd View commit details
    Browse the repository at this point in the history

  4. [addons] read the id attribute into a std::string where comparison is… 

    … made case-sensitive
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    fee8d45 View commit details
    Browse the repository at this point in the history

  5. [xml] use GetAttribute() where it makes the code clearer (and where u… 

    …sed enough to warrant the include)
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    ca295a1 View commit details
    Browse the repository at this point in the history

  6. [xml] use TiXmlNode::Attribute(foo, int|double) method where it tidie… 

    …s things up
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    29e767b View commit details
    Browse the repository at this point in the history

  7. [xml] read attributes into const char* where they're re-used immediately

    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    a42ee0d View commit details
    Browse the repository at this point in the history

  8. [skinsettings] setting type of skin settings needn't be compared case… 

    …-insensitive (we write them, we read them)
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    4b78439 View commit details
    Browse the repository at this point in the history

  9. [addons] have the 'subsetting' attribute and '' values attribute be c… 

    …ase-sensitive to drop some strcmpi()
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    6f5cd02 View commit details
    Browse the repository at this point in the history

  10. [settings] make the advancedsetting 'bydate' attribute for tvshow reg… 

    …exps case-sensitive (i.e. 'true')
    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    d2a666d View commit details
    Browse the repository at this point in the history

  11. [addons] drop duplicate if clause

    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    4b6c3b9 View commit details
    Browse the repository at this point in the history

  12. [cosmetic] align assignment block

    Jonathan Marshall committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    a362942 View commit details
    Browse the repository at this point in the history