StringUtils::Tokenize: clarify, simplify and optimize #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1164,19 +1164,16 @@ std::vector<std::string> StringUtils::Tokenize(const std::string &input, const s | |||
|
|
|||
| void StringUtils::Tokenize(const std::string& input, std::vector<std::string>& tokens, const std::string& delimiters) | |||
| { | |||
| // Tokenize ripped from http://www.linuxselfhelp.com/HOWTO/C++Programming-HOWTO-7.html | |||
| tokens.clear(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
1. pos must be string::npos when lastPos=string::npos, so no need to check pos != string::npos in the while condition. A != a || B != b = !(A==a && B==b) = !(B==b) = B != b 2. as pos needn't be in the condition, it mayaswell be in the while loop. 3. rename variables to reflect what they do.
|
@jmarshallnz Done. |
|
@jmarshallnz checked locally. |
jmarshallnz
added a commit
that referenced
this pull request
Jul 3, 2014
StringUtils::Tokenize: clarify, simplify and optimize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables names were wrong, no need to check "pos" for "string::npos", comments were incorrect (notice
// Find first "non-delimiter").@jmarshallnz ?