make must die #5157
Closed
make must die #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
@Fneufneu does cmake prioritize gmake on bsd? (my VM died in a diskcrash so easier to ask.. :)) @Montellese @wsnipex the installation CODE statements in addons likely need to be change to use ${CMAKE_MAKE_PROGRAM}. it's an improvement no matter as the make tool may be in the toolchain file. |
|
@notspiff sorry i don't know |
|
Let me close it for now. New PR can be opened if wanted/needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, we use gmake (gnu make) instead of make command. So properly use $(MAKE) variable in alll Makefiles.
And detect FreeBSD in bootstrap shell script to use the proper command.