Make it easier to rebrand from a single file #5175
Conversation
|
IMO this is something we should be doing. @topfs2 How much of your PR could be handled auto in this way? We mayaswell get as many of these things configurable as we can IMO. Not that we'll ever change our name again, but it would be good to reduce dependencies for others that may wish to do so. |
|
I'd suspect almost everything of it. Atleast Linux is quite straight forward. Just need to do some nice defines and it should be possible, could even use it to clean up some iffy looking vfs hooks which seems to assume /usr/share/xbmc even if you don't install there. |
|
rebased. after this is merged we can start from here. |
| if test "$APP_VERSION_MAJOR" != "" && test "$APP_VERSION_MINOR" != "" && test "$APP_VERSION_TAG" != "" \ | ||
| && test "$APP_VERSION_CODE" != "" && test "$APP_ADDON_API" != ""; then | ||
| if test "$APP_NAME" != "" && test "$APP_VERSION_MAJOR" != "" && test "$APP_VERSION_MINOR" != "" \ | ||
| && test "$APP_VERSION_TAG" != "" && test "$APP_VERSION_CODE" != "" && test "$APP_ADDON_API" != ""; then | ||
| final_message="$final_message\n Xbmc Version:\t${APP_VERSION_MAJOR}.${APP_VERSION_MINOR}-${APP_VERSION_TAG}" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
|
jenkins build this please @Montellese |
|
reverted the UPnP change for now. Windows has it somewhere else so better change it in one single commit. |
|
any objections for merging? |
|
looks good for me |
Make it easier to rebrand from a single file
|
Wouldn't "Organisation" make more sense than "CompanyName"? |
This is an initial POC for easier re-branding.
Before going any further i would like so more feedback if this is wanted.
Note: still needs to be rebased on current code/changes