[gif] - support for animated splash screens #5181
Conversation
|
@jmarshallnz i think i have taken care of some of your concerns now. The resolution diddling is not needed anymore because i now set it in render - so even transition between fullscreen and windowed is working fine now. So if i got you right you prefer to have the animation block the startup? This would be no big change code wise - but not sure if we really want that? (i kinda like the fact that it already fetches epg and starts services in the background)... |
|
Sorry for noise but would be nice to have this aware of movie like splashes http://forum.xbmc.org/showthread.php?tid=124124 |
|
@Memphiz is there a reason this has not been merged yet? There is a sticky on the forums for splash animations and some nice ones ready to go. http://forum.kodi.tv/showthread.php?tid=209673&page=22 |
|
The reason is that it was not decided how this should be handlded. Either make the animation blocking (delaying startup) or async (kodi startsup in the background while splash animation is running - which could lead to missing toast dialogs in the background). |
|
My view is it should block and delay startup. Purely from a UI point of view thats how I imagine it to work. |
|
My point of view is it shouldn't delay startup. If my hw allows to start quickly why should I wait until splash is finished? as an example splash on startup win7 doesn't delay startup. |
|
indeed no wait on splash |
|
@Memphiz I've reopened the pr: Memphiz#13 This should be reviewd and merged into this pr before it can be included imo. |
|
But the PR you opened is against a different branch. I need to dive into this branch mess again i think. Not sure when i get some time. |
…t least looped once
…ramemove if it is animated - do this until the animation was finished at least once to the end
|
To add to this - "no wait on splash" is something which is not covered yet at all. ATM its that the splash is played to the end and in the background Kodi loads up. What you want is that the splash is aborted. The question is which criteria is used for an abort in that case. |
Conflicts: xbmc/pictures/DllLibGif.h
Conflicts: xbmc/pictures/DllLibGif.h xbmc/pictures/Gif.cpp
Memphiz
force-pushed
the
animatedsplash
branch
from
0902f84
to
48abf37
Compare
|
ok - rebased and integrated the changes from @ace20022 - needs heavy squashing at the end. Please if someone could download http://sourceforge.net/projects/giflib/files/giflib-5.1.0.tar.bz2/download and upload it to the build-deps/sources on our mirrors it would be great. (can do sunday evening earliest...) |
|
I agree with zag that it makes sense to play splash until its done and kodi
|
|
is there a chance to get the animated gif support in, independet from the splash stuff? Or just get this PR in during next merge window? Couldn't believe that animated gifs are not working atm. |
|
they should working iirc some rbpi builds use gif spinners no? |
|
Also this whole animated gif stuff is out of my league tbh. I never grasped how this is ment to be integrated into the gui rendering. |
|
right - it could work as part of skin textures, but not in picture library - that's what I was referring to. |
that requires some more work
but buggy :p maybe I find some time (and motivation) within the next weeks. |
|
@ace20022 that would be great. Just one more question, would it make sense (or work at all) to implement the picture decoders etc in a similar way to audio encoders/decoders? So more like a interface and then have various add-ons as handlers for certain file types? That way we could have add-ons that use platform specific libs and as fallback our own implementation or alike. I'm not requesting any of this, just more of a general question if it could work and might be worth working towards. |
|
Animated gifs work in skins already. E.g. popcornmix@b854aba |
|
@popcornmix that only works correctly because that gif contains 11 full images/frames. |
Based on #5180 this adds support for animated splash screens.
I don't really think i have done the refactor of splash.cpp right - i just am not into gui stuff :(. But in case we somehow want to support animated splash screens for helix (because their were some animated ones in the logo suggestion thread in the forum) - i think this could be a base to work on it.
Also the rendering of the splash is done in our normal application render loop - this means XBMC is loading up in the background while the animation is playing.