New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video info scanner refactoring #5332
Conversation
Finally. Looks fine from a brief look. I´ll check in detail, run some tests and report back. |
Any refactor in this area is very much welcome. I'm not very knowledgeable in this code though so I don't feel comfortable commenting on the "unreachable" code that has been removed. Some of it simply becomes unreachable due to the changes made in this PR and I can't judge if these changes are alright or not. |
@Montellese I tried to do this very incremental so it would be possible to follow. The first two commits just copy-paste DoScan, then the tv part of movie scan, and vice versa, is removed. The 'unreachable' part is because of the |
69f61f7
to
94e1e68
Compare
@tamland @mkortstiege would be nice if we could get this cleanup soon so we can have wide testing for regressions. |
Too much conflict. Will rather redo if we don't come up with something better;) |
This is an attempt at untangling this spaghetti. Scanning movie folders vs tv folders hardly have anything in common at this point, making it impossible to follow. Please see individual commits for step-by-step.
If I have done this correctly, there should be no bug fixes or behavior changes in these commits.