New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxva: fix RelBuffer, use correct CDecoder object #5361
Conversation
@FernetMenta I'm afraid this one does not help.
|
nope, that's not what we want to do. if we did this next call to CreateDecoder would not release hw decoder. how can I reproduce your issue? do you have a sample and instructions? |
It's a bit tricky, can you join the chat? |
not now, boarding in 5 min ... maybe this evening. can you post a full debug log? |
Will post one in the team's dev section. |
@ace20022 I added another patch here. could you test this please? |
Yes, that one fixes the issue! |
jenkins build this please |
dxva: fix RelBuffer, use correct CDecoder object
@FernetMenta Seems to be related: http://forum.xbmc.org/showthread.php?tid=170329&pid=1793857#pid1793857 |
in GetFormat we create a new CDecoder object but some buffers requested with GetBuffer belong to the old CDecoder object. we need to make sure that RelBuffer returns the buffer to the correct object.
@ace20022 can you test this please. the problem was that RelBuffer was called on the new CDecoder object which closed itself because the refcount was 0.