Addsource jsonrpc

[topfs2]

Took out the addsource jsonrpc from the headless addition. @Montellese to review

[Tolriq]

Me again :)

Perhaps since adding this take : e99054a in account and handle allowsharing too to be complete ?

[Montellese]

Do we want to allow multiple directories per source like it can be done in the user interface? The API could support either a single string or an array of strings for the directory parameter.

Furthermore this is missing all the options that can be set per source (which are a bit ambiguous).

We'll probably have to extend the result of Files.GetSources to return all the options and having a Files.EditSource or something like that would be nice as well. But we can get Files.AddSource sorted out first and then we can start looking at the others.

[topfs2]

Yeah agree on the multiple directory, will change

[Montellese]

Looks a lot nicer already.

[topfs2]

@Montellese Kindof unsure on how we should do the parameters here if we want to support allowshare? It feels like its a property on the source, so unrelated to the scraper settings. But feels a bit odd to have name, paths, content, source_options, scraper_options?

[Montellese]

@topfs2: allowshare is a porperty of the source and not the scraper. As long as we don't allow scraper selection I wouldn't allow setting them anyway. We can still add those later as scrapersettings or something like that if we want.

Maybe we should try to find better naming for the source options? And we should also add descriptions as to which make sense for which media type and what they do.

PS: You still have the contentTypeFromString method in your code but it's unused now.

[Montellese]

Are you planning on getting this into shape for the next merge window?

[topfs2]

I could, not sure what was left to do on it though?

[Montellese]

From reading the previous comments I'd say

• remove your own CONTENT_TYPE contentTypeFromString(const std::string &content) as it's not used anymore.
• find better names for the source settings and add some documentation for them
• add a default value for every parameter / property that is not required
• optionally add support for allowsharing (but since this is not even supported in the GUI right now it's not that important as long as it gets set to true by default).

[jez500]

Hi All,
Id love to integrate this into Chorus is there any plans to look at this again or has it been replaced with another PR I can follow?