libCEC fixes #5610
libCEC fixes #5610
Conversation
opdenkamp
added
Type: Fix
|
jenkins build this please |
|
forgot to ping you too @sraue, sorry ;-) |
|
@opdenkamp Thanks for x64. Could you include x64 in future updates too? |
|
@Karlson2k sure |
|
@opdenkamp If you'd like to use new win32 package format: Karlson2k/xbmc@opdenkamp:libcec-2.2.0...libcec-2.2.0 |
|
okay thanks, will include it |
|
@opdenkamp You may also want to update text to Kodi/XBMC instead of XBMC. 😄 |
|
@Karlson2k there isn't really something saner to use for that ifdef check at compile time now, and it's only temporary, so I'll keep it like this for now. |
|
@opdenkamp As it's temporary and you'll manage to remove it soon anyway, I think it's not really important. |
|
yeah indeed, got more important things to do ;-) |
|
jenkins build this please |
opdenkamp
force-pushed
the
libcec-2.2.0
branch
2 times, most recently
from
b0c3178
to
b38a4e4
Compare
|
@MartijnKaijser pushed a fix for the OS X build thing. |
|
started it manual as it screwed up on fetching OSX |
| // double tap prevention timeout in ms. libCEC uses 50ms units for this in 2.2.0, so divide by 50 | ||
| m_configuration.iDoubleTapTimeout50Ms = GetSettingInt("double_tap_timeout_ms") / 50; | ||
| #else | ||
| // backwards compatibility. will be removed once the next major release of libCEC is out | ||
| m_configuration.iDoubleTapTimeoutMs = GetSettingInt("double_tap_timeout_ms"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
osx failed again. http://jenkins.kodi.tv/job/OSX-32/2237/console |
|
Ok I'm not around the pc atm so can't check it. Only had 5 minutes and thought it would have worked ;) @wsnipex can you revert the ppa thing please. Or just ignore broken CEC for a day, it's not that big of a problem for a testing ppa imo. -------- Oorspronkelijk bericht -------- osx failed again. http://jenkins.kodi.tv/job/OSX-32/2237/console — |
…does not change binary compatibility
…sion, because it will lead to issues when XBMC is rebuilt after a libCEC bump that changes something
opdenkamp
force-pushed
the
libcec-2.2.0
branch
from
b38a4e4
to
8f5ec65
Compare
|
I see what went wrong. It got fixed in libCEC's configure.ac, but the package still included the old version of the file, I suppose because I started the script before it got fully pushed. That's what you get when you try to get something done quickly before leaving ;-) jenkins build this please |
|
stupid jenkins didn't pull the last changes and still built the previous one, so obviously it failed again... |
|
jenkins is happy now |
This PR updates libCEC to v2.2.0, which is binary compatible with the previous version 2.1.4, and addresses a number of issues that have been reported in 2.1.4:
I've also fixed some other issues with CEC in XBMC:
@wsnipex packages are being build on our PPA https://launchpad.net/~pulse-eight/+archive/ubuntu/libcec
@Karlson2k you wanted an x64 build of it last time because you were playing with x64 builds on windows. I've uploaded it to the mirror in case you still need it.