[videodb]: keep empty series if hideemptyseries=true

[anaconda]

As of now (advanced setting) videolibrary.hideemptyseries seems to be quite useless as empty TV shows get always deleted when cleaning the library.

I do think it makes sense to keep empty TV shows based on that setting, otherwise there's no much to hide...

I delete episodes after I watch them, this causes the TV show to be deleted from the database and re-scraped every week. On devices like a Raspberry Pi this operation is not really instant.

I've been using this for months and I've been a more happy person since then...

(Hint: ?w=1)

[anaconda]

Oh, just found these:
http://trac.xbmc.org/ticket/15475 (Keep empty tv-shows in library - even after clean (was apparently possible pre gotham))
#5183 @Montellese

[Montellese]

Yeah as you found out I ran into this problem from the other direction i.e. I was confused why an empty tvshow wasn't removed.
This change should fix http://trac.xbmc.org/ticket/15475. It won't fix my problem but I've setup my library from scratch since then so I don't run into that problem anymore.

So this is fine with me.

[MartijnKaijser]

@topfs2
jenkins build this please

[anaconda]

Updated commit message to mention the ticket (added "Fixes #15475"). That was the only change.

Jenkins status before rebase: http://jenkins.kodi.tv/job/BuildMulti-PR/1716/

[MartijnKaijser]

@Montellese did you by any chance test this?

[Montellese]

Nope but it basically just prevents deleting tvshows that don't have any episodes during library cleaning if videolibrary.hideemptyseries is set in advancedsettings.xml.

[kib]

I am sorry i did not see this earlier, but this doesn't fix 15475 at all
It actually does the complete opposite.

The idea from 15475 is that empty series are shown in the GUI. What would the use be to only not delete them when they are hidden in the GUI ? Just to prevent the rescrape ?

[Montellese]

What do you mean with "complete opposite"? It changes the behaviour to not delete tvshows that are empty if videolibrary.hideemptyseries is set in advancedsettings.xml. So everyone with this option enabled should be better off. Everyone with this option disabled has the same behaviour as before.

From what I understood the main concern was that the shows were completely deleted and had to be rescraped (which might result in different artwork etc). This is prevented by this change.

[kib]

The initial trac ticket and subsequent IRC discussion was about someone who actually wants to see his tvshows even if there are no episodes in them (to see fanart, show info, etc)

Only keeping the show when it is hidden does not solve this, so the trac ticket should not be closed.

You say 'everyone with this option disabled has the same behaviour as before' which is not true. In gotham empty show folders were not deleted and showed up in skin views - this is why the 'hide empty series' was created for those people who did not want to show them.

[Montellese]

I just realized that @kib is right and this is wrong. I thought the advanced setting was "keep empty tvshows" but it's "hide empty tvshows" and it's not obvious what "hide" means. It could mean

• hide them but keep them in the library
• hide them because I don't care about them (so they can also be removed from the library)

So IMO this needs a different approach. Personally I have the advanced setting set to true because if I remove all episodes I also don't care about the tvshow anymore so I'd also want it to be removed from the library. This is not possible anymore and it feels wrong.

We would probably need a setting with more choices like

• don't keep empty tvshows
• keep empty tvshows but don't show them
• keep empty tvshows and also show them

Then I could choose "don't keep empty tvshows" while people like @kib could choose "keep empty tvshows and also show them". Did I miss any other possible cases?

@kib: do you agree that we should revert this?

[anaconda]

It is documented as "hide empty series in the video library": http://kodi.wiki/view/Advancedsettings.xml#videolibrary
To me that seems to imply that empty series are kept but not shown when browsing the video library.