Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osx] - fixed XBMCHelper was never updated #5678

Merged
merged 4 commits into from Nov 12, 2014
Merged

Conversation

Memphiz
Copy link
Member

@Memphiz Memphiz commented Nov 8, 2014

This PR

  1. removes the binary XBMCHelper from our tree
  2. ensures that XBMCHelper is built into the former directory of that stale binary
  3. Changes the code so that the XBMCHelper service is installed/uninstalled as soon as the user enables the "start xbmc via remote" option - this is needed as manual migration path for users which had this option enabled in gotham and update to kodi (the path to the service binary is changed / corrected during the toggle)

Well remote control service on osx is broken since the rebrand because the rebranded code was never in effect due to the stale binary in our tree ;)

Solution was verified working by the user who found the broken behavior (which essentially was that xbmc couldn't be started anymore via remote)

@Memphiz
Copy link
Member Author

Memphiz commented Nov 8, 2014

jenkins build this please

@Memphiz Memphiz added Helix Type: Fix non-breaking change which fixes an issue labels Nov 8, 2014
@MartijnKaijser MartijnKaijser added this to the Helix 14.0-beta3 milestone Nov 12, 2014
@Memphiz
Copy link
Member Author

Memphiz commented Nov 12, 2014

Hold on a bit ... there is an issue with currently built XBMCHelper binaries (they only work on osx 10.8 and later) - i need to add one more xcode flag for this when i am home to make the binary work on osx 10.6 and later too ... will keep you updated.

…h the one where the binary was in our tree before...
…anged ("allow startup of kodi via remote") - to instantly install/deinstall the launchagent -> needed for manual migration path from xbmc to kodi
@topfs2
Copy link
Contributor

topfs2 commented Nov 12, 2014

I think you know best if this needs in or not so approved :)

@Memphiz
Copy link
Member Author

Memphiz commented Nov 12, 2014

haha this reads "not so approved" at a first glance - but i got ya ... will now in a couple of mins - gald that we have our ios build slave which still runs 10.6 - i can test the resulting binary there :)

@Memphiz
Copy link
Member Author

Memphiz commented Nov 12, 2014

confirmed by user with 10.7 aswell ...

Memphiz added a commit that referenced this pull request Nov 12, 2014
[osx] - fixed XBMCHelper was never updated
@Memphiz Memphiz merged commit bec2747 into xbmc:master Nov 12, 2014
@Memphiz Memphiz deleted the xbmchelper branch November 12, 2014 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants