New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinuxHWDecoders: Adjust to new component logging #5695
Conversation
Fixes spamming :-) |
Should this not also apply to AMLCodec for AMLogic? What about new MMAL decoder for Raspberry Pi? And maybe OpenMax as OMX backend for Tegra too? |
yes it should but I think @fritsch does not have any of those platforms for testing. would be nice if someone could submit patches for the other codecs. |
@Hedda: Yeah send me a PR. I also only wanted to change only platforms @FernetMenta and me are maintaining. I did IMX, too as it did not receive many upstream love recently. So feel free to send a tested PR. |
@fritsch please cherry-pick Memphiz@8f672fb - can't do a pull request to you because your repo is not shown in the list of forks ... |
Thanks @Memphiz will do when I am back at home. |
I'll update MMAL codec to use this |
Oh no more components to move (and remove) to for log4cplus branch :P Seriously though, nice :) |
Do you guys want this for helix? I reckon it spews to much as is or? |
definitely for Helix |
@popcornmix just ping me when there is something to cherry-pick |
Currently only compile tested but you could grab this: I'll let you know if there's any problems with runtime testing. |
@popcornmix picking fails - I missed the mails for this pr for the last days, sorry. |
This is current version from newclock4: popcornmix@6a3eb89 |
@popcornmix I also had to fix some hunks and I saw that there are functional changes: fritsch@aab7f8b#diff-b0f003b8e9d3e5d42098e8aa62ac929eL921 and here fritsch@aab7f8b#diff-b0f003b8e9d3e5d42098e8aa62ac929eL928 Is my cherry-picked version okay? |
@fritsch your version contains a couple of code changes (from not currently upstreamed popcornmix@1ed7f9b) |
@davilla: Thx for spotting, I have changed it for @Memphiz so that functional and logging things are on separate lines |
jenkins build this please |
@popcornmix build fails in r-pi |
@popcornmix RPi build failed: fritsch@a339852#diff-b0f003b8e9d3e5d42098e8aa62ac929eR923 Seems like another branch with features not yet in mainline concerning m_preroll? |
jenkins build this please |
kicked again manual (sometimes it screws up pulling) |
Build succeeded (see http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-PR-Manually/43/ ) |
@popcornmix Yeah, already figred that and squashed it in my v2 version. jenkins build this please |
LinuxHWDecoders: Adjust to new component logging
Using new infrastructure for VDPAU, VAAPI, IMX