Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinuxHWDecoders: Adjust to new component logging #5695

Merged
merged 5 commits into from Nov 17, 2014

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Nov 11, 2014

Using new infrastructure for VDPAU, VAAPI, IMX

@fritsch fritsch added Helix Type: Fix non-breaking change which fixes an issue labels Nov 11, 2014
@fritsch
Copy link
Member Author

fritsch commented Nov 11, 2014

Fixes spamming :-)

@Hedda
Copy link
Contributor

Hedda commented Nov 12, 2014

Should this not also apply to AMLCodec for AMLogic?

What about new MMAL decoder for Raspberry Pi?

And maybe OpenMax as OMX backend for Tegra too?

@FernetMenta
Copy link
Contributor

yes it should but I think @fritsch does not have any of those platforms for testing. would be nice if someone could submit patches for the other codecs.

@fritsch
Copy link
Member Author

fritsch commented Nov 12, 2014

@Hedda: Yeah send me a PR. I also only wanted to change only platforms @FernetMenta and me are maintaining. I did IMX, too as it did not receive many upstream love recently.

So feel free to send a tested PR.

@Memphiz
Copy link
Member

Memphiz commented Nov 12, 2014

@fritsch please cherry-pick Memphiz@8f672fb - can't do a pull request to you because your repo is not shown in the list of forks ...

@fritsch
Copy link
Member Author

fritsch commented Nov 12, 2014

Thanks @Memphiz will do when I am back at home.

@popcornmix
Copy link
Member

I'll update MMAL codec to use this

@topfs2
Copy link
Contributor

topfs2 commented Nov 12, 2014

Oh no more components to move (and remove) to for log4cplus branch :P

Seriously though, nice :)

@topfs2
Copy link
Contributor

topfs2 commented Nov 12, 2014

Do you guys want this for helix? I reckon it spews to much as is or?

@FernetMenta
Copy link
Contributor

definitely for Helix

@fritsch
Copy link
Member Author

fritsch commented Nov 12, 2014

@popcornmix just ping me when there is something to cherry-pick

@popcornmix
Copy link
Member

Currently only compile tested but you could grab this:
popcornmix@852cd83

I'll let you know if there's any problems with runtime testing.

@fritsch
Copy link
Member Author

fritsch commented Nov 16, 2014

@popcornmix picking fails - I missed the mails for this pr for the last days, sorry.

@popcornmix
Copy link
Member

This is current version from newclock4: popcornmix@6a3eb89

@fritsch
Copy link
Member Author

fritsch commented Nov 16, 2014

@popcornmix I also had to fix some hunks and I saw that there are functional changes: fritsch@aab7f8b#diff-b0f003b8e9d3e5d42098e8aa62ac929eL921 and here fritsch@aab7f8b#diff-b0f003b8e9d3e5d42098e8aa62ac929eL928

Is my cherry-picked version okay?

@popcornmix
Copy link
Member

@fritsch your version contains a couple of code changes (from not currently upstreamed popcornmix@1ed7f9b)
Can you squash in this commit which should remove them:
popcornmix@55e36a0

@fritsch
Copy link
Member Author

fritsch commented Nov 16, 2014

@davilla: Thx for spotting, I have changed it for @Memphiz so that functional and logging things are on separate lines
@popcornmix done

@fritsch
Copy link
Member Author

fritsch commented Nov 16, 2014

jenkins build this please

@MartijnKaijser
Copy link
Member

@popcornmix build fails in r-pi

@fritsch
Copy link
Member Author

fritsch commented Nov 17, 2014

@popcornmix RPi build failed: fritsch@a339852#diff-b0f003b8e9d3e5d42098e8aa62ac929eR923 Seems like another branch with features not yet in mainline concerning m_preroll?

@fritsch
Copy link
Member Author

fritsch commented Nov 17, 2014

jenkins build this please

@MartijnKaijser
Copy link
Member

kicked again manual (sometimes it screws up pulling)
http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-PR-Manually/43/

@MartijnKaijser
Copy link
Member

@popcornmix
Copy link
Member

@fritsch
Copy link
Member Author

fritsch commented Nov 17, 2014

@popcornmix Yeah, already figred that and squashed it in my v2 version.

jenkins build this please

MartijnKaijser added a commit that referenced this pull request Nov 17, 2014
LinuxHWDecoders: Adjust to new component logging
@MartijnKaijser MartijnKaijser merged commit ff23683 into xbmc:master Nov 17, 2014
@MartijnKaijser MartijnKaijser added this to the Helix 14.0-beta4 milestone Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants