videodb: avoid an empty entry in string arrays #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
added
the
Type: Improvement
Montellese
added a commit
that referenced
this pull request
Jan 7, 2015
…rrays videodb: avoid an empty entry in string arrays
phil65
pushed a commit
to phil65/xbmc
that referenced
this pull request
Jan 10, 2015
…ng_arrays videodb: avoid an empty entry in string arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on my media import stuff I noticed that we fill in
std::vector<std::string>members ofCVideoInfoTagwith an empty string element instead of nothing if the value of the members is empty. So if we retrieve a movie without any genres the result will be thatCVideoInfoTag::m_genrewill contain a single empty string in the vector instead of simply being empty.I've been using this since the very beginning of my media import work and haven't seen any fallout but it's very difficult to determine if something is relying on the vector not being empty.