Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] properly select the hovered channel in the channel manager #6056

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

Jalle19
Copy link
Member

@Jalle19 Jalle19 commented Dec 30, 2014

Fixes #15473. The issue is that we don't consider an item in the list selected unless the arrow keys or page up/down is used. We don't recognize click events so without this it's not possible to use the channel manager dialog with a mouse.

The only question is if ACTION_MOUSE_MOVE is the best event to listen on? The original bug report mentioned that some other input methods are broken too, not just regular mouses.

@Jalle19 Jalle19 added Type: Fix non-breaking change which fixes an issue Backport: Needed Component: PVR labels Dec 30, 2014
@Jalle19
Copy link
Member Author

Jalle19 commented Jan 3, 2015

@xhaggi @opdenkamp forgot to ping you.

@xhaggi
Copy link
Member

xhaggi commented Jan 3, 2015

Looks good IMO

@opdenkamp
Copy link
Member

hmm not sure if that solves the issue for all inputs and if we have to listen to each ACTION_MOUSE_MOVE. best ask someone who's familar with the details of that code (@jmarshallnz I think?)

@jmarshallnz
Copy link
Contributor

By the looks what you're wanting is to pass actions through to the list so it can do it's thing (e.g. change focus based on mouse move or whatever). This seems to make sense to me.

@Jalle19
Copy link
Member Author

Jalle19 commented Jan 3, 2015

That's the intention, yes. @fritsch can you test this with the Wetek remote?

@fritsch
Copy link
Member

fritsch commented Jan 3, 2015

I currently cannot build the amlogic version of openelec ... you might want to ping @codesnake

@Jalle19
Copy link
Member Author

Jalle19 commented Jan 4, 2015

Oh yeah, forgot you said that. I say we merge even if we don't get a response in a few days, at least it fixes the issue for regular mice.

@opdenkamp
Copy link
Member

agreed. jenkins build and merge

jenkins4kodi added a commit that referenced this pull request Jan 5, 2015
@jenkins4kodi jenkins4kodi merged commit 905c227 into xbmc:master Jan 5, 2015
@MartijnKaijser MartijnKaijser added this to the Helix 15.0-alpha1 milestone Jan 10, 2015
phil65 pushed a commit to phil65/xbmc that referenced this pull request Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: PVR Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DVD (video_ts) not scanned to the library anymore
7 participants