Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Add support for rating videos #607

Closed
wants to merge 9 commits into from
Closed

[PATCH] Add support for rating videos #607

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2012

Hello devs.

Just pulling this request because Jeff17 / jmarshall are AFK since 3-5 months (?) but the work seems OK and this feature is awesome.

Original post : http://forum.xbmc.org/showthread.php?p=841627
Ticket #11750 (accepted Patches) : [PATCH] Add support for rating videos : http://trac.xbmc.org/ticket/11750

I made this fork from jmarshall's repository from https://github.com/jmarshallnz/xbmc/tree/doozan-video_ratings (seems to be the most updated version according to trac ticket).

Thank you guys.

Cheers.

@doozan
Copy link

doozan commented Jan 5, 2012

Hi,

This is my code and it's a bit stale right now. At a minimum, the DB revision needs to be bumped up -- I think we're at revision 58 right now. If any xbmc maintainer is willing to pull this into the tree when it's ready, I would be more than happy to update the patches.

@ghost
Copy link
Author

ghost commented Jan 10, 2012

Great you are alive !! ;)

I'm sorry I can't help you cause I'm not a dev but I really hope to see this code in XBMC soon.

Support for rating videos is just THE feature needed in XBMC... Cross the fingers.

Cheers.

@master-lincoln
Copy link

This would be awesome!

@jmarshallnz
Copy link
Contributor

Closing as far too out of date. If someone wants to bring it up to date it may be reconsidered.

@jmarshallnz jmarshallnz closed this May 8, 2012
@ghost
Copy link
Author

ghost commented May 28, 2012

How many beers to complete and add this feature ?

tru pushed a commit to plexinc/plex-home-theater-public that referenced this pull request Sep 5, 2013
tru pushed a commit to plexinc/plex-home-theater-public that referenced this pull request Nov 12, 2013
That was kind of a stupid bug, forgot to dispatch the actual timeline
job.
Fixes xbmc#634
Fixes xbmc#607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants