[pvr] don't persist channel groups (includes members) unless the group is fully loaded #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jalle19
added
Type: Improvement
|
we need the db id's of channels for group memberships, so we do need to persist these for the internal group i think. this change should be fine for the other groups. |
|
@opdenkamp the inserted ID is set for the channel object after the query has run. |
|
Sorry I thought we were talking about another PR. |
|
I couldn't find any downsides to this, even after resetting the database. |
|
right, let me check this properly when i got a tree checked out again. just checking emails sent by github atm (and it's quite a lot of them ;-)) |
|
i guess the pr changed in the meantime, or i was talking about the other PR too :) |
opdenkamp
pushed a commit
that referenced
this pull request
Jan 20, 2015
[pvr] don't persist channel groups (includes members) unless the group is fully loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6091 I noticed that we persist everything to database quite a few times while starting the PVR manager. I've changed it so it only attempts to persist things after they've been fully loaded. At least when running in Visual Studio this speeds up the manager startup time a bit.
@opdenkamp do you think this is correct?