[confluence] fix cosmetic scrollbar shwing for half setting height #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is both cosmetic and functional. When pulling AudioOSDsettings (ignore the fact this is videoOSDSettings as both share same xml.) the audio settings the scrollbar is present only for half a height of the last field So really to see all settings fully you need to scroll some minimal amount for no reason. This fixes that minor yet annoying thing.
|
Looks harmless, thanks. |
|
cool, thx! |
ronie
added a commit
that referenced
this pull request
Jan 6, 2015
[confluence] fix cosmetic scrollbar shwing for half setting height
phil65
pushed a commit
to phil65/xbmc
that referenced
this pull request
Jan 10, 2015
[confluence] fix cosmetic scrollbar shwing for half setting height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is both cosmetic and functional.
When pulling AudioOSDsettings (ignore the fact this is videoOSDSettings as both share same xml.) the audio settings the scrollbar is present only for half a height of the last field
So really to see all settings fully you need to scroll some minimal amount for no reason.
This fixes that minor yet annoying thing.
before/after crude screenshots
@ronie for review etc.