cppcheck performance fixes in filesystem/ #6123
Conversation
| CMythSession::CMythSession(const CURL& url) : CThread("MythSession"): | ||
| m_hostname(url.GetHostName()), | ||
| m_username(url.GetUserName() == "" ? MYTH_DEFAULT_USERNAME : url.GetUserName()), | ||
| m_password(url.GetPassWord() == "" ? MYTH_DEFAULT_PASSWORD : url.GetPassWord()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Rebase needed. |
tobbi
force-pushed
the
cppcheck_perf_filesystem
branch
from
8561ae4
to
4e50551
Compare
|
Done rebasing. |
|
jenkins build this please |
|
Jenkins build seems to be failing. And I think I know why. Gonna update the PR soon. |
tobbi
force-pushed
the
cppcheck_perf_filesystem
branch
from
4e50551
to
9994538
Compare
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
|
Okay, the failed jenkins build were for the previous update. MythSession.cpp: In constructor 'XFILE::CMythSession::CMythSession(const CURL&)': I think I fixed that already. |
| @@ -36,7 +36,7 @@ namespace XFILE | |||
| virtual bool AllowAll() const { return true; } | |||
| virtual DIR_CACHE_TYPE GetCacheType(const CURL& url) const { return DIR_CACHE_ALWAYS; }; | |||
| private: | |||
| bool GetRootAndChildString(const std::string strPath, std::string& strBQRequest, std::string& strXMLRootString, std::string& strXMLChildString ); | |||
| bool GetRootAndChildString(const std::string& strPath, std::string& strBQRequest, std::string& strXMLRootString, std::string& strXMLChildString ); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tobbi
force-pushed
the
cppcheck_perf_filesystem
branch
from
9994538
to
e7e407f
Compare
|
jenkins build this please |
|
and again: jenkins build this please |
cppcheck performance fixes in filesystem/
cppcheck performance fixes in filesystem/
This is mostly iterator pre/ postfix fixes, but also removing string initializations and moving things to initializer list.