Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confluence] left align addon descriptions #6124

Merged
merged 1 commit into from
Jan 7, 2015

Conversation

tamland
Copy link
Member

@tamland tamland commented Jan 6, 2015

This is causing a lot of weird stretching as people put long links etc. in the descriptions. See for instance info dialog for Rom Collection Browser and KinoPoisk in Info 2 view.

@ronie
Copy link
Member

ronie commented Jan 6, 2015

ideally this should be handled by Kodi i think.
ie. when the length of the text exceeds the width of the textbox, it should truncate the text instead of trying to squeeze it in.

i did a bit of testing with align=justify and sometimes the text indeed gets truncated and sometimes it does not. probably our justify logic is a bit flawed.

"System->Appearance->International->Character"
^ gets truncated

"System->Appearance->International->Character set"
^ does not get truncated and weird stretching occurs

@tamland
Copy link
Member Author

tamland commented Jan 6, 2015

Perhaps that was a poor example if it's a bug. Those were the extreme cases. There's clearly visible stretching in almost every description, especially info2, with a few exceptions where it looks ok. These two boxes are just too small for justify align if you ask me.

When you mention it the algorithm looks very funky. It adds space between characters too. I don't think that's normal for justify alignment..

@ronie
Copy link
Member

ronie commented Jan 7, 2015

i'm fine with this going in as-is though.

let's hope someone can have a look at the underlying cause of the problem.

ronie added a commit that referenced this pull request Jan 7, 2015
[confluence] left align addon descriptions
@ronie ronie merged commit 3327f5e into xbmc:master Jan 7, 2015
@MartijnKaijser MartijnKaijser modified the milestone: Helix 15.0-alpha1 Jan 10, 2015
phil65 pushed a commit to phil65/xbmc that referenced this pull request Jan 10, 2015
[confluence] left align addon descriptions
@tamland tamland deleted the addon-descr-align branch August 9, 2015 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants