don't force skins to use a panel container #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Yup should be good. |
mkortstiege
added a commit
that referenced
this pull request
Jan 7, 2015
don't force skins to use a panel container
phil65
pushed a commit
to phil65/xbmc
that referenced
this pull request
Jan 10, 2015
don't force skins to use a panel container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently Kodi forces skins to use a panel container in the filebrowser for container id=451
(this is the container that's used when browsing for images).
in case container 451 is not a panel container, Kodi will use container id=450 instead
(this container is normally used when browsing for files/folders)
this limits the skinner in the way they want to present the layout of the filebrowser.
the patch fixes that. (tested and it works as expected).
please review if this change is correct (c++ n00b here).
see: http://forum.kodi.tv/showthread.php?tid=121568